Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP2040 longint support #4044

Merged
merged 5 commits into from
Jan 22, 2021
Merged

RP2040 longint support #4044

merged 5 commits into from
Jan 22, 2021

Conversation

DavePutz
Copy link
Collaborator

Memory is sufficient on the RP2040 for longint support. My build for the raspberry_pi_pico went from 499040 bytes to 512380 bytes used, leaving 536196 free.

dhalbert
dhalbert previously approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It might have just been an oversight. Will merge after a good build.

@tannewt
Copy link
Member

tannewt commented Jan 21, 2021

Can you enable it at the port level instead of board? We should be able to assume we can fit it since they always use external flash.

@dhalbert dhalbert self-requested a review January 21, 2021 22:52
@dhalbert dhalbert requested a review from tannewt January 22, 2021 04:07
@dhalbert
Copy link
Collaborator

@tannewt Could you smoke-test this when the build finishes? Thanks.

@dhalbert
Copy link
Collaborator

I moved the setting to mpconfigport.mk

@ladyada
Copy link
Member

ladyada commented Jan 22, 2021

tested on hardware

>>> print(0x1000000)
16777216
>>> print(0x10000000000)
1099511627776
>>> print(0x10000000000000000000000)
309485009821345068724781056

ladyada
ladyada approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print(0x1000000)
16777216
print(0x10000000000)
1099511627776
print(0x10000000000000000000000)
309485009821345068724781056

@dhalbert dhalbert merged commit f50edc2 into adafruit:main Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@dhalbert dhalbert Awaiting requested review from dhalbert

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DavePutz @tannewt @dhalbert @ladyada @siehputz