Add support for a 'haxpress' external SPI flash build for stm32f411ce Black Pill board

[djix123]

Similar to the QT PY the Black Pill / STM32F411CE board has pads for an external flash. This pull request adds a board version that supports an external flash soldered onto those pads.
[There is also a version of the board available with the external flash already present]

[djix123]

It looks like the automated build fails with a duplicate PID - I copied over the config files from the base board - is there something I should update?

[dhalbert]

I'm a little confused. When you say

[There is also a version of the board available with the external flash already present]

do you mean you can buy such a version, or we already have a board definition? If you can buy the version, should we use that designation? It sounds identical to the haxpress version, except maybe for choice of flash chip.

[djix123]

Yes, there are two versions available to buy: one with the flash and one without the flash present.
(there's currently only a board definition for the version without the flash present - this pull request adds a board definition for the version with the flash present - either as bought or added later)

[dhalbert]

Is there a name or different model number for the commercial version with flash?

pinging @hierophect here for any comment

[djix123]

Not that I can tell - on the WeAct/Aliexpress store - its just a case of selecting either with or without ... no obvious name difference.

[hierophect]

@dhalbert I knew about the pads when adding the board, but I didn't realize they had a version that actually shipped with it - I assumed the user would be adding their own custom flash board, so I left the flash pin definitions commented out so they could easily compile a custom build for whatever flash they were using.

My first thought is to handle this with a build flag, but that won't make it available in the build artifacts or on the website. It's the exact same product, but with a simple physical modification, so I don't think it deserves a new PID, but I guess we don't have an "alt-build" system to use other than just making a completely new board for it.

[hierophect]

Is there some way to bypass the duplicate PID checker? I think that's what would make the most sense here, and it might come up again for other future boards with "variant" builds.

[dhalbert]

We can provide another USB PID no problem, since we provided the original, just like Py QT with/without flash. I am more concerned with what we would call it, since the commercial version is not a "haxpress". And also, what flash chip is provided on the commercial version, so we can add it to the list of possible chips for a version with flash.

We have some other examples:
cp_sapling_m0 vs cp_sapling_m0_spiflash
sparkfun_qwiic_micro_no_flash vs sparkfun_qwiic_micro_with_flash
...with_flash is fine with me, and I think covers both the home-added and commercial versions.

[hierophect]

...with_flash is fine with me, and I think covers both the home-added and commercial versions.

I agree, simplest answer is the best.

[djix123]

The commercial version has a Winbond W25Q64JV ... my pull request references a W25Q64FV as I originally built this for a hand soldered version. The JV and FV are compatible so the build works for both.

Would you like me to resubmit the pull request with '_haxpress' replaced with '_with_flash'?

[dhalbert]

Thanks for the addition! Besides the inline comments, could you change the board directory name to stm32f411ce_blackpill_with_flash?

[dhalbert]

forgot the new PID

[djix123]

Thanks for the help! Hopefully all good now!

[dhalbert]

All set, thanks!