Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Enhancement for Touch Alarm #3969

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Fixes and Enhancement for Touch Alarm #3969

merged 2 commits into from
Jan 12, 2021

Conversation

microdev1
Copy link
Collaborator

A couple of fixes and an enhancement for TouchAlarm.

Fixes :-

Enhancement :-

  • Add ability to have multiple touch alarms in light-sleep.

- prevent touch alarm initialization if not set
- fix wake_alarm is set to touch alarm on autoreload
- add ability to have multiple touch alarms in light sleep
dhalbert
dhalbert previously approved these changes Jan 11, 2021
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested the PR artifact on a MagTag. With no TouchAlarm enabled, power consumption is back down, about 230uA. Did you turn off something else that would have lowered it from the 260uA I saw before?

Deep-sleeping with a TouchAlarm enabled brings the sleep current back up to 2.something mA. Do you think it is possible to get this down further by setting the duty cycle lower with setting changes via touch_pad_set_meas_time() or other changes? We can ship with the higher current now, as long as TimeAlarm is low-current, but it would be nice to have lower consumption for touch.

@dhalbert
Copy link
Collaborator

@microdev1 could you merge from adafruit to get circuitpython.pot in sync, and the push again? Thanks. I could not push to your PR

@microdev1
Copy link
Collaborator Author

Did you turn off something else that would have lowered it from the 260uA I saw before?

Not that I know of... the changes here are TouchAlarm specific.

Do you think it is possible to get this down further by setting the duty cycle lower with setting changes via touch_pad_set_meas_time() or other changes?

The default touchpad config settings are being used at the moment... it might be possible to get lower current consumption by altering them. There is also a concern of stuff like ULP being on during sleep as esp_sleep_pd_config() is explicitly called.

We can ship with the higher current now, as long as TimeAlarm is low-current, but it would be nice to have lower consumption for touch.

I agree... current in mA range is too high.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For now, ignoring a couple of de_DE builds that are too big.

@dhalbert dhalbert merged commit 679b465 into adafruit:main Jan 12, 2021
@microdev1 microdev1 deleted the TouchAlarm branch January 14, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants