Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new CIRCUITPY_DEBUG flag passes DEBUG into C preprocessor #3957

Merged
merged 1 commit into from
Jan 11, 2021
Merged

new CIRCUITPY_DEBUG flag passes DEBUG into C preprocessor #3957

merged 1 commit into from
Jan 11, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jan 9, 2021

Fixes #3857, and provides a general mechanism to know what the make DEBUG= flag is in the C preprocessor.

@dhalbert dhalbert requested review from tannewt and jepler January 9, 2021 03:19
@dhalbert dhalbert force-pushed the gcc10-debug-builds branch from 7fe4b68 to 255ffa9 Compare January 9, 2021 04:07
@dhalbert
Copy link
Collaborator Author

dhalbert commented Jan 9, 2021

Switching to draft because removing the always_inline from translate() seems to be messing up qstr lookup in some cases.

@dhalbert dhalbert marked this pull request as draft January 9, 2021 15:24
@dhalbert dhalbert marked this pull request as ready for review January 9, 2021 20:23
@dhalbert
Copy link
Collaborator Author

dhalbert commented Jan 9, 2021

Switched backed from draft to ready-to-merge. This appears to have been my fault, giving the wrong device to the JLinkGDBServer command. I was giving SAMD51J19 instead of SAMD51P20 while trying to debug a Grand Central. The firmware size was >512kB, and I'm guessing it was not writing the part above 512kB.

tannewt
tannewt approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This might mean the english strings are included in the debug binary then.

@tannewt tannewt merged commit ba507a8 into adafruit:main Jan 11, 2021
@dhalbert dhalbert deleted the gcc10-debug-builds branch January 11, 2021 23:56
@dhalbert
Copy link
Collaborator Author

I am still trying to figure out why a DEBUG=1 build where I change the CFLAGS to -Os is hugely too large on, say, Metro M0 Express.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building DEBUG=1 fails with gcc10 changes and -flto enabled
2 participants
@dhalbert @tannewt