Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32-s2: Adding authmode keyword #3944

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

BennyE
Copy link

@BennyE BennyE commented Jan 6, 2021

grafik

While this works fine, I'm not entirely confident with my change around the following, as I need an additional variable.
e.g.

strcpy(authmode, "OPEN");

Can I get around this? I've tried/attempted to directly strcpy into cstr, but this resulted in an unhappy compiler.

I'm planning to add pairwise_cipher & group_cipher, unless you'd prefer to be a separate PR (thus this is a draft).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get around this? I've tried/attempted to directly strcpy into cstr, but this resulted in an unhappy compiler.

I suggested an alternative that I think will work.

I'm planning to add pairwise_cipher & group_cipher, unless you'd prefer to be a separate PR (thus this is a draft).

Either way. Smaller is generally better.

ports/esp32s2/common-hal/wifi/Network.c Outdated Show resolved Hide resolved
@BennyE BennyE marked this pull request as ready for review January 7, 2021 22:22
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor nitpick. Thanks!

ports/esp32s2/common-hal/wifi/Network.c Outdated Show resolved Hide resolved
Avoid to use yet another variable.

Co-authored-by: Scott Shawcroft <scott@tannewt.org>
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 081249f into adafruit:main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants