Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect pin assignment on header #3925

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Fixed incorrect pin assignment on header #3925

merged 2 commits into from
Jan 4, 2021

Conversation

UnexpectedMaker
Copy link

IO13 is for blue LED
IO14 is the correct pin header between IO18 and IO12 - this was marked as IO13 by mistake
The silk is wrong (shows IO13), but hardware is correct as IO14, but IO14 was not included in pins.c
Silk will be updated on next PCB production run
Also added comments against custom pins

jepler and others added 2 commits January 4, 2021 09:52
Update main with latest 6.0.x
IO13 is for blue LED
IO14 is the correct pin header between IO18 and IO12
The silk is wrong (shows IO13), but hardware is correct as IO14, but IO14 was not included in pins.c
Silk will be updated on next PCB production run
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test with hardware

@UnexpectedMaker
Copy link
Author

UnexpectedMaker commented Jan 4, 2021

did not test with hardware

I have tested this with current shipping hardware. I'm running this right now on my test jigs.
Sorry, I should have stated that on the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants