Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX : common_hal_reset_pin() #3888

Merged
merged 1 commit into from
Dec 29, 2020
Merged

FIX : common_hal_reset_pin() #3888

merged 1 commit into from
Dec 29, 2020

Conversation

microdev1
Copy link
Collaborator

This PR fixes issue #3886.

jepler
jepler previously approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good change. Could go further and simplify existing cleanup code which DID check pins for being NULL, but not necessary in this PR.

@microdev1
Copy link
Collaborator Author

@jepler I removed the redundant NULL checks.

@microdev1 microdev1 requested a review from jepler December 28, 2020 18:12
@jepler
Copy link
Member

jepler commented Dec 29, 2020

Thank you!

@jepler jepler merged commit 7401aa8 into adafruit:main Dec 29, 2020
@microdev1 microdev1 deleted the fix-reset-pin branch December 29, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microdev1 @jepler