esp32-s2: wifi enhancement to include countrycode #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Dec 23, 2020
|
All suggested changes implemented. I also fixed the trailing line/whitespace that caused the CI to be unhappy.
|
…works correct as per the protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to access the country code as announced by the Wi-Fi access point (if it announces it).
The workaround via esp_wifi_get_country() is necessary as esp_wifi_sta_get_ap_info() returns wifi_ap_record_t where wifi_country_t is empty. Reference to ESP-IDF bug report/issue: espressif/esp-idf#6267
The discussion with @tannewt happened on this commit (so that there is more context, as questions are associated to line numbers):
BennyE@ae3b440
(next time, I'll do this via a draft PR - Thank you! :))
As I haven't added new objects, it should not be necessary to add something to the gc - but I'd love to hear @dhalbert feedback. :)