unmounted filesystems start as ejected #3862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3709.
Undoes bda3267 from #3680. The problem is that a board that starts unconnected does not start with unejected drives; they should be ejected when
boot.py
is entered.The original change saved 20 bytes. I tried reversing the sense of the
ejected[]
array, calling itnot_ejected[]
. (mounted
was too confusing, because it has two meanings: one for TinyUSB, and one for the filesystem.) But the code was harder to read and the change caused the addition of a little extra code elsewhere to reverse the sense of various tests. So it ended up that only 12 bytes were saved. I think that was not worth the cost of harder-to-read-code.This fix is only needed for
main
: the original change was done after 6.0.0.Tested via
boot.py
on a QTPy.