-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for AT25DF641A SPI Flash #3824
Conversation
I converted this to a draft while you sort out the CI. Undraft once it's happy and I'll review. |
Included #3794 on this PR. There was issues with build CI tests with the comments on the devices.h file. I included the 64MiB MX SPI Flash, it's good to go after it passed CI I believe. |
Can you take another look at this @tannewt ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for trying and adding these new chips.
This is related to issue #3782 for adding support for the AT25DF641A 8MiB SPI Flash.
I've included a commented out section in the addition for the other SPI Flash referenced in my comment on the issue. I'm still awaiting the chip and will do another PR to add support once I can verify.
I tested the AT25DF641A on the Qt Py (A little tight soldering this chonky chip) and I was able to verify expanded storage and functionality with the chip.
Passes local pre-commit as well, so there shouldn't be any CI issues.