Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for AT25DF641A SPI Flash #3824

Merged
merged 8 commits into from
Dec 21, 2020
Merged

Adding Support for AT25DF641A SPI Flash #3824

merged 8 commits into from
Dec 21, 2020

Conversation

skerr92
Copy link

@skerr92 skerr92 commented Dec 14, 2020

This is related to issue #3782 for adding support for the AT25DF641A 8MiB SPI Flash.

I've included a commented out section in the addition for the other SPI Flash referenced in my comment on the issue. I'm still awaiting the chip and will do another PR to add support once I can verify.

I tested the AT25DF641A on the Qt Py (A little tight soldering this chonky chip) and I was able to verify expanded storage and functionality with the chip.

Passes local pre-commit as well, so there shouldn't be any CI issues.

@tannewt tannewt marked this pull request as draft December 15, 2020 01:25
@tannewt
Copy link
Member

tannewt commented Dec 15, 2020

I converted this to a draft while you sort out the CI. Undraft once it's happy and I'll review.

@skerr92
Copy link
Author

skerr92 commented Dec 16, 2020

Included #3794 on this PR. There was issues with build CI tests with the comments on the devices.h file. I included the 64MiB MX SPI Flash, it's good to go after it passed CI I believe.

@skerr92 skerr92 marked this pull request as ready for review December 16, 2020 19:07
@skerr92
Copy link
Author

skerr92 commented Dec 21, 2020

I converted this to a draft while you sort out the CI. Undraft once it's happy and I'll review.

Can you take another look at this @tannewt ?

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for trying and adding these new chips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants