Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32s2: Reserve UART pins only if DEBUG=1 is set to address issue 3811 #3817

Merged
merged 3 commits into from
Dec 15, 2020

Conversation

BennyE
Copy link

@BennyE BennyE commented Dec 11, 2020

This addresses issue #3811

Same patch for all esp32s2 boards. Tested on featherS2 (see screenshot below).

Python code for test:

import board
import busio
uart = busio.UART(board.TX, board.RX, baudrate=115200)
uart.write(bytes("Test123", "utf8"))

grafik

@BennyE
Copy link
Author

BennyE commented Dec 11, 2020

@tannewt please check if my changes in the Makefile are valid. It works as expected, thanks for the due-dilligence. I didn't realise that the debug was enabled/disabled via sdkconfig files and DEBUG=1 on make command didn't set the CFLAG.

grafik

@tannewt tannewt self-requested a review December 14, 2020 23:27
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants