esp32s2: Ensure proper wifi_disconnect and reset

[BennyE]

This should fix #3743

[BennyE]

I have to add that I tested this just with a code that runs some i2c and has "import wifi". I didn't have time to test this longer and some additional fixes might be necessary.

[jepler]

I didn't get a chance to test this for myself, but it seems like a good find and extremely plausible as a reason for problems subsequent to importing wifi. Thank you!

[jepler]

The single CI failure can be ignored.

[BennyE]

I didn't get a chance to test this for myself, but it seems like a good find and extremely plausible as a reason for problems subsequent to importing wifi. Thank you!

Hi @jepler , thanks for your review and positive comment. I tried this briefly with a "real wifi setup" and I ran into a backtrace. I'll look into this during my evening (writing this post during my lunch break). Please don't merge yet, I should have done this as a draft and was overly excited & confident. I'll get back to you all later today.

[skieast]

Yes. Was playing with that as well. Some esp32 forum idf comments have pointed to similar issues with making sure that disconnect is finished. Cant test until later as I'm mostly skiing in the mornings here. :) My various experiments fixed the CTRL-C CTRL-D issue but broke the wifi. Meaning i would get a core panic and backtrace.

[BennyE]

#3803 fixes what this pull request was meant for. Thank you, Bruce! :)