Block all tasks (not interrupts) during flash erase #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we risk running code from flash while an erase is in progress, crashing and corrupting the file system. Related to micropython#3744
|
ill try out artifacts when ready |
dhalbert
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Looks good based on the documentation. Doing a websearch on CONFIG_SPI_FLASH_YIELD_DURING_ERASE, I see that OTA update with it turned off could cause IDF 3.x watchdog triggers, e.g. espressif/esp-idf#4916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we risk running code from flash while an erase is in
progress, crashing and corrupting the file system.
Related to #3744