Exit faster on recv when TLS connection closed #3759
Conversation
When a TLS connection is closed by the server it usually sends a notice. We see this incoming byte with lwip_ioctl and try to read it. The read returns 0 but we keep trying anyway. Now, we quit trying when we get zero back. If the connection was still alive it'd either read a byte or delay until a byte could be read.
There was a problem hiding this comment.
At first I didn't understand what you were saying about "TLS internal" bytes, since I saw the call to esp_tls_get_bytes_avail, and that is documented as returning the number of application data bytes. But, there's also the call to lwp_ioctl which would return TLS internal bytes. What I'm wondering is, it seems that esp_tls_FOO calls handle the tls and non-tls cases. It makes me wonder why the lwip_ioctl is needed at all; I conjectured it was from pre-TLS-support days but that's not the case.
Feel free to merge if this lwip_ioctl concern of mine is just a distraction.
Testing performed: none
I believe I needed
|
When a TLS connection is closed by the server it usually sends a
notice. We see this incoming byte with lwip_ioctl and try to read
it. The read returns 0 but we keep trying anyway. Now, we quit
trying when we get zero back. If the connection was still alive
it'd either read a byte or delay until a byte could be read.