Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32s2: Do a full scan when channel/BSSID are not given #3727

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

BennyE
Copy link

@BennyE BennyE commented Nov 19, 2020

Whenever you connect to your Wi-Fi network / SSID just with the following code the first AP that matches the SSID will be chosen, even if there is another AP with better signal strength (RSSI).

wifi.radio.connect(mysecrets["ssid"], mysecrets["password"])

This commit will enhance the function to do a full scan (across all channels) whenever channel/BSSID are omitted.

@BennyE BennyE changed the title Wifi full scan esp32s2: Do a full scan when channel/BSSID are not given Nov 19, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One small thing but good otherwise!

ports/esp32s2/common-hal/wifi/Radio.c Show resolved Hide resolved
Copy link
Author

@BennyE BennyE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding requested changes.

ports/esp32s2/common-hal/wifi/Radio.c Show resolved Hide resolved
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit a80bf22 into adafruit:main Nov 23, 2020
@BennyE BennyE deleted the wifi-full-scan branch November 23, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants