Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulab: Update to release tag 1.1.0 #3694

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Conversation

jepler
Copy link
Member

@jepler jepler commented Nov 15, 2020

Disable certain classes of diagnostic when building ulab. We should submit patches upstream to (A) fix these errors and (B) upgrade their CI so that the problems are caught before we want to integrate with CircuitPython, but not right now.

tannewt
tannewt previously approved these changes Nov 16, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt
Copy link
Member

tannewt commented Nov 16, 2020

meowbit and thunderpack builds ran out of space.

tannewt
tannewt previously approved these changes Nov 17, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just needs a merge.

@dhalbert
Copy link
Collaborator

@jepler want to get this in to the beta?

@jepler
Copy link
Member Author

jepler commented Nov 23, 2020

Rebased to resolve translation conflict, no other changes intended.

@jepler jepler requested a review from tannewt November 23, 2020 16:13
jepler and others added 2 commits November 23, 2020 10:23
Disable certain classes of diagnostic when building ulab.  We should
submit patches upstream to (A) fix these errors and (B) upgrade their
CI so that the problems are caught before we want to integrate with
CircuitPython, but not right now.
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tannewt tannewt merged commit f8dcb25 into adafruit:main Nov 23, 2020
@jepler jepler deleted the update-ulab2 branch November 3, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants