-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSRAM support to ESP32S2 #3315
Conversation
When configured the CircuitPython heap will be on the external RAM. When not available, the heap will be 48k inside the IDF heap.
hi want me to test on hardware? |
If you like. I tested on WROVER and FeatherS2 on stream. |
ok this loaded onto my saola but i cant seem to get displayio demo on oled running
->
i dont know if its related - this is my first time in a long time trying out circuitpy on esp32s! |
I'll try a control from |
@ladyada What module does your Saola have? Does it have PSRAM? I suspect your issue may not be related to this PR. |
Works on my saola_wrover
|
I can confirm a null reference exception when attempting to use DisplayIO on the Saola Wrover. Investigating. |
@ladyada @tannewt I've confirmed that the issue with DisplayIO also happens on main and thus is probably unrelated to this PSRAM update. I've opened a new issue for it here: #3334. @ladyada if you'd like to keep testing this PR, I think most other sketches should still work, you just got unlucky with the one you tried landing on a new bug! It only occurs when the screen is physically plugged in, so removing it should allow you to recover your filesystem. |
Should I wait for this for 6.0.0-alpha.3? |
@dhalbert Want to approve? Seems like it's ready to go in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and has been confirmed as working. Thanks!
When configured the CircuitPython heap will be on the external RAM.
When not available, the heap will be 48k inside the IDF heap.