Split pulseio.PWMOut into pwmio #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us better granularity when implementing new ports because PWMOut is commonly implemented before PulseIn and PulseOut. Fixes micropython#3211
|
@dhalbert We should be able to do beta releases after this. |
hierophect
requested changes
Aug 18, 2020
There was a problem hiding this comment.
Looks like CI is concerned about stubs, not sure what that's about. I found a couple of mis-labeled comments but it looks good to me overall - you covered everything in Display and and the config settings that I can think of. Either this or ESP32-PulseIO will need some tweaks depending on which goes in first, of course.
|
Ok, everything is passing now. Please take another look. |
hierophect
approved these changes
Aug 25, 2020
|
Looks good, thanks! |
RichardBronosky
added a commit
to RichardBronosky/kmk_firmware
that referenced
this pull request
Apr 13, 2021
Upstream in CircuitPython, they moved PWM functionality out of pulsio into a dedicated module. See: adafruit/circuitpython#3299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us better granularity when implementing new ports because
PWMOut is commonly implemented before PulseIn and PulseOut.
Fixes #3211