allocate_display_bus: fix bug where in-use bus would be returned #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
previously requested changes
Aug 17, 2020
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
|
oh github! You create such an opportunity for mirth! Scott's suggested change had two parts; after accepting one, the code would be broken. But at that point the second suggestion was no longer able to be accepted in the web UI. I did it by hand, hopefully it's right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I factored out "allocate_display_bus" I introduced a bug where the code checked if the display was allocated, not the bus. Correct the in-use check.