Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require await in async #3202

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Require await in async #3202

merged 2 commits into from
Jul 27, 2020

Conversation

kvc0
Copy link

@kvc0 kvc0 commented Jul 25, 2020

disallows using await outside of an async def scope

await ''  # syntax error, not async def (also '' is not awaitable but this does change not fix that)

def f():
  await ''  # syntax error, not async def

def f():
  async with real_async_function() as a:  # syntax error, not async def

def f():
  async for i in arange():  # syntax error, not async def

My branch: Build CI

@dhalbert
Copy link
Collaborator

This is all set for review, right? Thanks.

@kvc0
Copy link
Author

kvc0 commented Jul 27, 2020

This is all set for review, right? Thanks.

Yep, should be.

@@ -1336,10 +1332,6 @@ msgstr ""
msgid "Pull not used when direction is output."
msgstr ""

#: ports/stm/ref/pulseout-pre-timeralloc.c
msgid "PulseOut not supported on this chip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being deleted? Maybe you need to merge adafruit/main into your branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. This was my mistake in my PR. This was an error I added but deleted before merging. 🙄

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 7f804fd into adafruit:main Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants