Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board Raytac MDBT50Q-DB-40 #3127

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Add new board Raytac MDBT50Q-DB-40 #3127

merged 5 commits into from
Jul 8, 2020

Conversation

Arudinne
Copy link

@Arudinne Arudinne commented Jul 7, 2020

This is the board: https://www.raytac.com/product/ins.php?index_id=81. This board appears to be a simple breakout / demo board for all of the pins on the Raytac MDBT50Q-1MV2 module used in other products and available here: https://www.adafruit.com/product/4078

I used the nRF Connect suite and a JLINK EDU Mini to load the same UF2 bootloader used by the PCA10059 and then I was able to install CircuitPython without issue.

This is the output from boot_out.txt:

Adafruit CircuitPython 6.0.0-alpha.1-17-ga7844205b on 2020-07-07; MDBT50Q-DB-40 with nRF52840

REPL via USB serial seems to work, as does copying over files via USB but I haven't had a chance to test any higher level functions.

Arudinne added 2 commits July 7, 2020 12:27
	new file:   ports/nrf/boards/raytac_mdbt50q-db-40/bootloader/6.0.0/pca10056_bootloader_6.0.0_s140.zip
	new file:   ports/nrf/boards/raytac_mdbt50q-db-40/mpconfigboard.h
	new file:   ports/nrf/boards/raytac_mdbt50q-db-40/mpconfigboard.mk
	new file:   ports/nrf/boards/raytac_mdbt50q-db-40/pins.c
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new board def! Just a couple suggestions.

ports/nrf/boards/raytac_mdbt50q-db-40/pins.c Show resolved Hide resolved
@Arudinne Arudinne requested a review from tannewt July 7, 2020 19:41
@Arudinne
Copy link
Author

Arudinne commented Jul 8, 2020

I'm sure why the merge check is failing. It seems to be indicating an issue with the white space that I can't see on my end.

@dhalbert
Copy link
Collaborator

dhalbert commented Jul 8, 2020

I'm sure why the merge check is failing. It seems to be indicating an issue with the white space that I can't see on my end.

pre-commit is complaining blank lines with spaces in them in pins.c. So check the blank lines between the pin lines.

Check if your editor has an option or a plug-in to trim trailing whitespace when it saves the file. I have that enabled in emacs and it saves a lot of manual fixing.

I was able to pip3 install pre-commit, and then run it by hand. The build log nicely describes how to do that.

@Arudinne
Copy link
Author

Arudinne commented Jul 8, 2020

Looks like it should be good now?

@dhalbert
Copy link
Collaborator

dhalbert commented Jul 8, 2020

D1, D2, and D3 are green, red, and blue, so would you be interested in pretending to use them as a single RGB status LED, similar to the PCA10059?

@Arudinne
Copy link
Author

Arudinne commented Jul 8, 2020

The PCA10059 has one single color LED and one RGB LED, where as this has 3 physically separate LEDS and an empty set of pads for a 4th LED. If you think it's better to have it pretend to be a single RGB LED I'm not entirely against it, I just don't think it accurately reflects the hardware to treat it that way. See below.
7eddbe6a2b3f2bd8152c1df95b17f443
nRF52840_dongle_kit_content

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert
Copy link
Collaborator

dhalbert commented Jul 8, 2020

I'm willing to go along with your current treatment of the LEDs. @tannewt do you want to review further?

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy as-is too. I didn't realize they were separate LEDs and either approach works for me.

@tannewt tannewt merged commit ce214e8 into adafruit:main Jul 8, 2020
@Arudinne Arudinne deleted the Raytac_MDBT50Q-DB-40 branch July 8, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants