Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RGB/BGR colors in Stage #2777

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Fix RGB/BGR colors in Stage #2777

merged 3 commits into from
Apr 20, 2020

Conversation

deshipu
Copy link

@deshipu deshipu commented Apr 15, 2020

This makes the colors used by the stage library compatible with those
used by the displayio library.

This makes the colors used by the stage library compatible with those
used by the displayio library.
@deshipu
Copy link
Author

deshipu commented Apr 15, 2020

I'm not sure to which branches I should make this pull request.

@tannewt
Copy link
Member

tannewt commented Apr 16, 2020

master is good. We'll do a pre-release from it shortly.

tannewt
tannewt previously approved these changes Apr 16, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@tannewt
Copy link
Member

tannewt commented Apr 16, 2020

Hi hi, please push a new commit. The CI had trouble last night and it needs a push. Maybe add yourself as the copyright for these files?

@deshipu
Copy link
Author

deshipu commented Apr 20, 2020

Those tests sure take a while to run...

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI isn't working so I'll just merge.

@tannewt tannewt merged commit a4d86b9 into adafruit:master Apr 20, 2020
@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Apr 20, 2020

I'm not sure what to do about the CI actions. But, I had a stale copy of this page open apparently
I was able to build this and test with Pew Pew M4. All colors are appearing normal for me now. Thank you deshipu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants