Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulab: Get updates from upstream #2767

Merged
merged 7 commits into from
Apr 14, 2020
Merged

ulab: Get updates from upstream #2767

merged 7 commits into from
Apr 14, 2020

Conversation

jepler
Copy link
Member

@jepler jepler commented Apr 13, 2020

This has about 15 enhancements and bug fixes, mostly from @v923z. It removes the two "known problems" we mentioned in the 5.1.0 and 5.2.0 release notes.

@tannewt
Copy link
Member

tannewt commented Apr 13, 2020

Changes look ok. Needs a CI poke.

@jepler
Copy link
Member Author

jepler commented Apr 14, 2020

Complicating things, I think it was based off an old ref rather than master. Rebased and force-pushed, which will give Actions a fresh crack at it.

@jepler jepler requested a review from tannewt April 14, 2020 02:07
@v923z
Copy link

v923z commented Apr 14, 2020

@jepler v923z/micropython-ulab#96 fixes a bug in the dot function, in case you want to pull it in.

@jepler
Copy link
Member Author

jepler commented Apr 14, 2020

Updated to include v923z/micropython-ulab#96.

@tannewt
Copy link
Member

tannewt commented Apr 14, 2020

Unix port isn't building to run the tests.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit ada102d into adafruit:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants