added enable_dim_neopixel(), disable_dim_neopixel(), set_dim_level()

[asherlie]

This adds 3 functions to the samd module for the user to control the behavior of the neopixel:

• enable_dim_neopixel()
• disable_dim_neopixel()
• set_dim_level()

enable_dim_neopixel and disable_dim_neopixel turn on and off dim neopixel mode. set_dim_level takes in an integer from 0-255 and sets the brightness level of dim neopixel mode. The default brightness level for dim neopixel mode is 40. set_dim_level(0) will turn off the neopixel.

[tannewt]

Looks like the test is failing because the code is too large for the Arduino Zero, Gemma M0 and Trinket M0. How about adding a single set_rgb_status_brightness to rgb_led_status.c and removing the enable/disable calls? 0 can disable and !=0 can enable implicitly.

[dhalbert]

The 2.0.0-rc2 builds have only 56 bytes free on non-Express boards. You can get back some more space by lowering -finline-limit in the Makefile. -finline-limit=57 right now. Lower it only a few at a time (like 2-5), since it will cost a little performance somewhere.

[asherlie]

I'll check it out tonight. I think I'll go the set_rgb_status_brightness route and not mess with the -finline-limit.

[dhalbert]

I agree with @tannewt about the API, though with only 56 bytes left, you may still need to make room by fiddling with -finline-limit.

[asherlie]

Oops. I'll fix this soon. Defined some variables in the wrong place relative to #ifdefs.

[tannewt]

Looks nearly there! Thanks!

One more change I'd like to see is that rgb_status_brightness be uint8_t. You'll need to check the value you get in samd_set_rgb_status_brightness to make sure its between 0 and 255 and throw a ValueError if its not.

[tannewt]

Looks good! Thank you!