wifi.radio.enabled=False causes error with debug mode on

[tyeth]

CircuitPython version

latest (main) ~9.1beta5  DEBUG BUILD

Code/REPL

calling `wifi.radio.enabled = False` (before deep sleeping)

Behavior

wifi:pm stop, total sleep time: Assertion '*fmt == '%' || !"unsupported fmt char"' failed, at file mpprint.c:586

Description

Appears the debug message contains "%" which is not supported, or at least that was my impression after visiting micropython#3004

Additional information

No response

[dhalbert]

I think it may contain ... %<something>, where the <something> is not supported.

[jepler]

There's a hack somewhere that tries to print espidf messages via mp_printf so they are visible on the repl, not requiring a separate debug uart. I guess this isn't compatible with all formats used in espidf

[tyeth]

That was my thunk, thanks Dan. I did see a successful log example when searching for the time related string. Forgot to mention running on an itsy bitsy esp32

…

On Sat, 6 Jul 2024, 16:49 Dan Halbert, ***@***.***> wrote: I think it may contain ... %<something>, where the <something> is not supported. — Reply to this email directly, view it on GitHub <#9406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTBZ434ZTHXPOHLOYPQPU3ZLAGX7AVCNFSM6AAAAABKOQ65P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHAYDENRTHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tannewt]

This is the printf connector:

circuitpython/ports/espressif/supervisor/port.c

Lines 489 to 497 in 8fbbb59

	#if CIRCUITPY_CONSOLE_UART
	static int vprintf_adapter(const char *fmt, va_list ap) {
	return mp_vprintf(&mp_plat_print, fmt, ap);
	}
	void port_serial_early_init(void) {
	esp_log_set_vprintf(vprintf_adapter);
	}
	#endif

I do need to comment it out from time to time when debugging too.

[jepler]

let's just back it out if it causes crashes.