Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPY_TOOL_LONGINT_IMPL not set correctly in some ports #5782

Closed
jepler opened this issue Dec 27, 2021 · 0 comments · Fixed by #5783
Closed

MPY_TOOL_LONGINT_IMPL not set correctly in some ports #5782

jepler opened this issue Dec 27, 2021 · 0 comments · Fixed by #5783
Labels
broadcom Raspberry Pis with Broadcom chips bug mimxrt10xx iMX RT based boards such as Teensy 4.x rp2040 Raspberry Pi RP2040

Comments

@jepler
Copy link
Member

jepler commented Dec 27, 2021

While reviewing

The problem is that the setting of LONGINT_IMPL is after it use in the ifeq lines. This means LONGINT_IMPL is treated as empty at line 5, 9, and 13 and so none of the -mlongint-impl lines are taken.

The consequence of this is that if there are frozen files (there aren't, in these ports) and they use long ints it won't work.

@jepler jepler added bug mimxrt10xx iMX RT based boards such as Teensy 4.x rp2040 Raspberry Pi RP2040 broadcom Raspberry Pis with Broadcom chips labels Dec 27, 2021
jepler added a commit to jepler/circuitpython that referenced this issue Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcom Raspberry Pis with Broadcom chips bug mimxrt10xx iMX RT based boards such as Teensy 4.x rp2040 Raspberry Pi RP2040
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant