Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Solved) update correct values for Macronix MX25R1635F 8MiB SPI flash #3558

Closed
StackRduino opened this issue Oct 15, 2020 · 2 comments
Closed

Comments

@StackRduino
Copy link

Credits to Brian — Brian Dean bsd@bdmicro.com BDMICRO, LLC https://www.bdmicro.com

According to the datasheet for the MX25R1635F, the JDEC should be 0xc2, 0x28, 0x15. In the devices.h file, the capacity parameter is specified as 0x18 for that chip. So the value is incorrect in devices.h

/ Settings for the Macronix MX25R1635F 8MiB SPI flash.
// Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/7595/MX25R1635F,%20Wide%20Range,%2016Mb,%20v1.6.pdf
// In low power mode, quad operations can only run at 8 MHz.
#define MX25R1635F {
.total_size = (1 << 21), /* 2 MiB /
.start_up_time_us = 800,
.manufacturer_id = 0xc2,
.memory_type = 0x28,
.capacity = 0x15,
.max_clock_speed_mhz = 33, /
8 mhz for dual/quad */
.quad_enable_bit_mask = 0x80,
.has_sector_protection = false,
.supports_fast_read = true,
.supports_qspi = true,
.supports_qspi_writes = true,
.write_status_register_split = false,
.single_status_byte = true, \

@tannewt
Copy link
Member

tannewt commented Oct 15, 2020

Hi! Please make a pull request with the change. We'd love to see it fixed. Thanks!

More info on how to make a pull request here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

@tannewt tannewt added this to the Long term milestone Oct 15, 2020
@tannewt tannewt added bug good first issue Hacktoberfest Beginner friendly issues for Hacktoberfest event help wanted labels Oct 15, 2020
@adafruit-adabot adafruit-adabot removed the Hacktoberfest Beginner friendly issues for Hacktoberfest event label Nov 1, 2020
StackRduino added a commit to StackRduino/circuitpython that referenced this issue Dec 17, 2020
Correct capacity value for the MX25R1635F from 0x18 to 0x15 (tested and working)
refer to 
adafruit#3558
@microdev1
Copy link
Collaborator

Closing... fixed in #3838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants