Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Waveshare RP2040 One to CircuitPython.org #1446

Merged
merged 16 commits into from
Aug 7, 2024
Merged

Add Waveshare RP2040 One to CircuitPython.org #1446

merged 16 commits into from
Aug 7, 2024

Conversation

johnnohj
Copy link
Contributor

@johnnohj johnnohj commented Aug 7, 2024

Submitted following successful merge here.

@johnnohj johnnohj marked this pull request as ready for review August 7, 2024 20:43
makermelissa
makermelissa requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change template.md to add search filters that are specific to your board. Instead add your features under the description area.

@johnnohj
Update template.md
a014b4a 
Omitted 'features' changes for separate PR
@johnnohj johnnohj mentioned this pull request Aug 7, 2024
Closed
makermelissa
makermelissa approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I had forgotten about the issue to add castellated pads, but also would like to mark all boards at the same time when adding.

@makermelissa makermelissa merged commit 6ec46b6 into adafruit:main Aug 7, 2024
2 checks passed
@johnnohj
Copy link
Contributor Author

johnnohj commented Aug 7, 2024

Absolutely makes sense - I'd like to help if that issue has stalled. Thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnohj @makermelissa