Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for pylint, jQuery #344

Merged
merged 1 commit into from
May 17, 2023

Conversation

tekktrik
Copy link
Member

  • Updates .pylintrc to fix pylint warning for specifying exceptions in overgeneral-exceptions
  • Fixes jQuery for Sphinx

Paired with adafruit/cookiecutter-adafruit-circuitpython#228

@tekktrik tekktrik requested review from FoamyGuy and kattni May 14, 2023 17:16
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jquery change looks good to me.

(same as cookiecutter) I'm less familiar with the pylint change, but found SO answer: https://stackoverflow.com/questions/75370815/pylint-specifying-exception-names-in-the-overgeneral-exceptions-option-without that looks like appropriate solution applied here.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay! Thanks so much!

@kattni kattni merged commit 04a772f into adafruit:main May 17, 2023
@tekktrik tekktrik deleted the patch/overgeneral-exceptions branch July 31, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom panel missing in libraries docs. (jquery missing)
3 participants