Pb error msgs

[tyeth]

Adds extra logging on encoding errors for protobuf/nanopb.
Aimed at better logging for better diagnosing of all connectivity / reliability issues, but specifically an issue with pyportal titanos (#585).

Also incorporates PR #589 for RSSI logging to serial (with PR feedback), and PR #590 resetting the esp32 Airlift coprocessor on disconnect which also checks for connectivity if an unsuccessful MQTT ping and triggers reconnect if necessary.

Lastly adds a macro to "retry a function until timeout with custom retry delay, while verifying return value/func-argument against a condition". Then refactors the networking port specific code to use it in a less delay heavy manner

[tyeth]

Feedback welcomed, just threw this together for that PyPortal Titano user, ran it and saw data flow normally but never saw an error so it's utility remains untested.

[brentru]

@tyeth Have you tested this on physical HW yet and played around with it?

[tyeth]

Mainly just ran a few sensors and components on a board or two, didn't see anything not working

…

On Fri, 17 May 2024, 18:42 Brent Rubell, ***@***.***> wrote: @tyeth <https://github.com/tyeth> Have you tested this on physical HW yet and played around with it? — Reply to this email directly, view it on GitHub <#584 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTBZ4ZYEU4ET2CGUU2YOCDZCY6Q5AVCNFSM6AAAAABHNK565KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGEYDIMBUGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tyeth]

Skipping this release (beta83), will be reviewed in context (PyPortal Titano) next week, then make it into 84.

[brentru]

@tyeth Overall, this PR is great. It addresses issues when the PB encoder/decoder doesn't work as we expect, airlift-specific issues.

However, it still needs some tweaking before I want to merge. Could you review the following feedback and either comment so we can have a convo about it, or add commits to address them? Thanks!

[tyeth]

@brentru ready for re-review, I've dealt with the formatting issue + feedback, retested on pyportal titano.
Found the RSSI virtual issue. I'd left a breadcrumb of info in another commit message, easily found after walking away from the problem, I just needed to call the method getRSSI unqualified (without WS.) when inside Wippersnapper.cpp/base-class.
Lastly I was trying to print the RSSI before connect when no longer storing it, so refactored to print in the check_valid_ssid network interface methods instead (where the scan happens and we can briefly get access to all RSSIs before connecting).

awaiting re-review

[tyeth]

Tagging @brentru as ready for re-review

[tyeth]

@brentru ready for review
Cleaned up the feedback, added the pico cert for staging and wifi101 ignores for esp32 / 8266, and improved the wifi network logging (mentions which SSID it's just connected to).

[brentru]

LGTM! This is a lot of changes, do you want to cut a new release for it?

[tyeth]

That's a very good idea. Easier roll back that way, but should be fine ☺️