Add bh1750 driver #445
Merged
Add bh1750 driver #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 10, 2023 22:50
brentru
requested changes
Jul 11, 2023
brentru
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
This PR looks OK to me and addresses adding the BH1750 component per example code: https://github.com/Starmbi/hp_BH1750/blob/master/examples/Non_blocking/Non_blocking.ino.
Thank you for contributing, @whatisbyandby!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brentru
This PR adds the I2C Component driver for the BH1750 sensor.
Product URL: https://www.adafruit.com/product/4681
Link to Component Definition issue: adafruit/Wippersnapper_Components#19
This drivers uses the hp_BH1750 library to communicate with the sensor
Library Repository: https://github.com/Starmbi/hp_BH1750
This implementation uses the One Time Measurement feature of the BH1750, with the default quality and MTreg settings recommended in the datasheet for the BH1750. Each reading should take approximately 120ms.