fix : Passthrough logic inside hardReset() #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to read the Passthrough checkbox state directly inside of hardReset(). This is to avoid issuing a reset on passthrough boards (M4 + ESP coprocessor).
This was tested locally, but I believe by forcing a read of the passthrough checkbox the web hosted code will also work.
Hardware successfully tested with this update:
Feather V2
PyPortal
Low risk level of making things worse. The Webserial_ESPTool has not worked in passthrough mode since August 2024.