Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Passthrough logic inside hardReset() #304

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

mikeysklar
Copy link
Contributor

A small change to read the Passthrough checkbox state directly inside of hardReset(). This is to avoid issuing a reset on passthrough boards (M4 + ESP coprocessor).

This was tested locally, but I believe by forcing a read of the passthrough checkbox the web hosted code will also work.

Hardware successfully tested with this update:

Feather V2
PyPortal

Low risk level of making things worse. The Webserial_ESPTool has not worked in passthrough mode since August 2024.

A small change to read the Passthrough checkbox state directly inside of hardReset(). This is to avoid issuing a reset on passthrough boards (M4 + ESP coprocessor).
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's merge and try this.

@dhalbert
Copy link
Contributor

oops, minor formatting issue

@dhalbert dhalbert merged commit 01bf969 into adafruit:main Nov 15, 2024
1 check passed
@dhalbert
Copy link
Contributor

I did a shift-reload on the deployed page, but I'm still getting:

ESP Web Flasher loaded.
Connecting...
Connected successfully.
Try hard reset.
[Object.debug:196] Finished read loop
Error: Couldn't sync to ESP. Try resetting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants