Add S3 support #25
Merged
Add S3 support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I just want to test this with the ESP32-S3 and ESP32-S2. I don't remember why I had the different efuse address for the S2, but the change looks correct on the surface. |
makermelissa
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Ok, I must have broke something in regards to the Mac Address stuff since it's not working on either chip, even with the old values. Since the updated Mac Fuse Address matches the official esptool.py and that's the direction I've been moving with this, let's stick with it.
makermelissa
pushed a commit
that referenced
this pull request
Nov 4, 2022
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.