Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased timeout to reduce errors #14

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Increased timeout to reduce errors #14

merged 2 commits into from
Aug 2, 2021

Conversation

makermelissa
Copy link
Contributor

@makermelissa makermelissa commented Jul 30, 2021

This makes it more reliable on ESP32. This is needed to get the NVM Generator code working.

@makermelissa makermelissa requested a review from ladyada July 30, 2021 22:39
@makermelissa makermelissa requested a review from brentru August 2, 2021 15:08
@brentru
Copy link
Member

brentru commented Aug 2, 2021

@makermelissa is this PR implemented anywhere for me to test the changes?

@makermelissa
Copy link
Contributor Author

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makermelissa LGTM, tested by wiping an ESP32 at a baud rate previously not connecting. :shipit:

@makermelissa makermelissa merged commit e66d5c3 into adafruit:main Aug 2, 2021
makermelissa pushed a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants