Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code for PyPortal IoT Plant Monitor #1129

Merged
merged 20 commits into from
Jun 16, 2020

Conversation

jimbobbennett
Copy link
Contributor

This is an updated sample for using the PyPortal with Azure IoT Central. This example uses the new Azure IoT SDK that was recently published.

This PR is raised as draft and will need to go live when updates to the ALS module are ready, but not before.

@jimbobbennett jimbobbennett marked this pull request as ready for review May 30, 2020 23:24
@ladyada
Copy link
Member

ladyada commented Jun 1, 2020

@brentru wanna review? :)

PyPortal_Azure_Plant_Monitor/azure_gfx_helper.py Outdated Show resolved Hide resolved
PyPortal_Azure_Plant_Monitor/code.py Show resolved Hide resolved
PyPortal_Azure_Plant_Monitor/code.py Show resolved Hide resolved
PyPortal_Azure_Plant_Monitor/code.py Show resolved Hide resolved
@jimbobbennett
Copy link
Contributor Author

@brentru - updated with your requested changes, and updated the draft pages in the ALS guide to match.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimbobbennett this looks good to merge, thank you for updating.

@jimbobbennett
Copy link
Contributor Author

Thanks @brentru - to avoid confusion I assume we can hold off merging till the ALS guide changes are approved?

@brentru
Copy link
Member

brentru commented Jun 2, 2020

@jimbobbennett Sure, I'll hold off until the guide is updated.

@brentru brentru merged commit 6d6d4bf into adafruit:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants