Add Adafruit-Blinka to requirements

[evaherrada]

No description provided.

[sommersoft]

Does this actually need Blinka? Its just a couple functions returning an array of waveforms...

If Blinka is being added solely because the library is on PyPI, then might as well add it to the setup.py: https://github.com/adafruit/Adafruit_CircuitPython_Waveform/blob/master/setup.py#L37

[evaherrada]

I’m no really sure. I was just basing this off of it being on the contributing page on the circuitpython website under the list of things that were missing adafruit-blinka as a requirement.

[makermelissa]

#6 was a PR for the same thing and it was closed because it was determined that this wasn't needed. Can we put this on an Adabot ignore list so it doesn't show up as something that needs to be done?

[evaherrada]

That’d probably be good. I can try to look into that but I’m very unfamiliar with adabot.

[sommersoft]

Can we put this on an Adabot ignore list

Funny thing... I was just working on Adabot and noticed that it was already added to the ignore list. 🌮s all around! 😄

[makermelissa]

Is the Adabot ignore list not working then?

[sommersoft]

I'll be able to verify in a few; I have it running now. I was running a specific validator which doesn't use the LIBRAIRES_DONT_NEED_BLINKA list.

[evaherrada]

It is now but it wasn’t when I made the PR a few weeks ago.

[sommersoft]

I think it was done during PyCon. I know it was something that came up before (PyCon18, perhaps). but the conversation had a long break...

[makermelissa]

Ok, cool.

[makermelissa]

I think it was PyCascades that the conversation last came up. Possibly during PyCon18 too, but I wasn’t around then.

[sommersoft]

Yeah, PyCascades seems more likely. The Issue was opened in Feb. 😉