-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements continuous mode #21
Conversation
* remove atexit and cleanup * fix the formatting and method naming
@Smankusors Please let me know your status on this PR. Let us know if you're stuck or need assistance with anything. Thanks for the contribution! |
hmm to be honest I'm actually don't want to implement Should it create new class to handle the context or just use thanks for replying btw 😉 |
@tannewt Can you weigh in on this? It's outside my knowledge. Thanks! |
I'd just use self. Multiple sensors could either do nested |
Hmm alright. But unfortunately I left my device and sensor on my workplace. And there's still pandemic going on. I will continue to work on this when I got access back. |
Hello @Smankusors have you been able to get access to the device, are you still interested in this PR? let us know. Thanks :) |
uh oh, yeah I do already have access to the device, but then I got busy with other things. I will try to find some free time to continue on this. Thanks for the reminder. |
@Smankusors Thanks :) |
alright I just implemented the context manager for the continuous mode. Also I add an example for the simple continuous 😉 hmm it seems like the code I wrote kinda look weird, I defined a class ( |
@tannewt Could you review please. Thanks |
I think you can simplify it a bit by having |
I see... how about the failing checks? Should I add the... license? Copy paste from other files? |
@Smankusors for the copyright license yes, that is the way to go, as you adding the example you will need to add your name, or if you prefer you github user. |
OK I simplified the manager, and also add the license to my example codes. Is the license format I entered correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested successfully with feather RP2040 and VL53L0X
Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.3.12 from 1.3.11: > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#32 from tekktrik/fix/update-value-error Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.5.0 from 3.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#21 from Smankusors/master > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.5.12 from 2.5.11: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#90 from kattni/specify-python > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.5 from 5.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#91 from Eason010212/fix-remaining-length > update rtd py version
Fixes #19
Also with an example.
Tested it on Nvidia Jetson Nano with 2 VL53L0X (but it's not from Adafruit).