New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid getting stuck in while loop during file write #51

Merged

gamblor21 merged 2 commits into adafruit:main from calcut:main

Oct 15, 2022

Contributor

calcut commented Oct 7, 2022

Suggested fix for
#50

TBH I'm still soak-testing this, I'll update here if it doesn't solve my problem.

calcut added 2 commits

October 7, 2022 10:28


          timeout to avoid getting stuck in while loop

da525ba


          pylint disables (tips on not needing these welcome)

tekktrik requested a review from a team

October 7, 2022 18:50

gamblor21 approved these changes

View reviewed changes

Member

gamblor21 left a comment

Looks good to me. It could result in a slightly longer timeout of the main loop but as it is using a for loop for timing I am assuming it is inconsequential.

gamblor21 merged commit bb2fc8c into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@eaa233b)

d7df474

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL34x to 1.12.7 from 1.12.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADXL34x#37 from tekktrik/dev/fix-value-error

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.5.10 from 1.5.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#29 from tekktrik/dev/fix-type-annotation

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.10.6 from 3.10.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#90 from tekktrik/dev/fix-example-import

Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 2.1.13 from 2.1.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_PM25#25 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.3.15 from 3.3.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#51 from calcut/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.17 from 0.5.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#30 from jepler/make-tests-pass

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 0.5.2 from 0.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#15 from FoamyGuy/smaller_file_read_buffer

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.16.7 from 1.16.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#61 from deshipu/png

Updating https://github.com/adafruit/Adafruit_CircuitPython_Ticks to 1.0.8 from 1.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Ticks#8 from adafruit/try-time-ticksms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet