eCO2 -> CO2 #5
Merged
eCO2 -> CO2 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding co2 to the design guide listing too? https://github.com/adafruit/circuitpython/blob/main/docs/design_guide.rst#sensor-properties-and-units Thanks! |
|
I see that TVOC is in all caps. Do we want |
|
CO2 is a technical spelling, i'd prefer its in all caps |
|
OK, I'll revise this accordingly. |
|
thank you :) |
|
OK, commits updated, and the docs PR is here: adafruit/circuitpython#4070 |
|
thanks, gonna wait till @tannewt is around and approves the new 'sensor type' |
tannewt
approved these changes
Jan 26, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 28, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#5 from rpavlik/eco2-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a real CO2 sensor, so the docs and API should reflect that - see recent equivalent change to the arduino library. I opted to lowercase the property name now that we don't need mixed case to distinguish "e" from "CO2", so scd30.eCO2 is now just scd30.co2.
I also fixed some typos I saw as I was going thru.
Fixes #4