Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CRLF line ending to LF #181

Closed
wants to merge 1 commit into from

Conversation

DJDevon3
Copy link
Contributor

@DJDevon3 DJDevon3 commented Apr 2, 2024

This file has 608 line endings in CRLF format instead of LF format and is making my local pre-commit throw about 600 errors. Because there's no actual line changes it won't allow me to submit without changing a line. So deleted a blank line . Can then commit to force the file to switch from CRLF to LF... hopefully.

I used Notepad++ with EOL symbols visible to ensure the switch from CRLF to LF. The only way it might stay as CRLF is if my Github desktop converts them back to CRLF (which is possible). This commit is an attempt to fix pre-commit errors.

Capture

The only change in this commit is to convert invisible line endings to LF and 1 deleted blank line.

This file has 608 line endings in CRLF format instead of LF format and is making my local pre-commit throw about 600 errors.  Because there's no actual line changes it won't allow me to submit without changing a line.  So deleted a blank line . Can then commit to force the file to switch from CRLF to LF.
@justmobilize
Copy link
Collaborator

@DJDevon3 this must of been from something on your side. The file does not have CRLF in the repo...

@DJDevon3
Copy link
Contributor Author

DJDevon3 commented Apr 3, 2024

After looking into pre-commit and git configs I can see how dumb of a PR this is. Yes it's Github Desktop that is adding them on checkout. This is a problem specifically plaguing Windows Github Desktop users. I wrote a powershell script to fix it.

@DJDevon3 DJDevon3 closed this Apr 3, 2024
@DJDevon3 DJDevon3 deleted the DJDevon3-Requests-Fix-CRLF branch April 3, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants