Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multiple cookies example #176

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Update multiple cookies example #176

merged 2 commits into from
Apr 10, 2024

Conversation

DJDevon3
Copy link
Contributor

@DJDevon3 DJDevon3 commented Mar 25, 2024 •
edited
Loading

Example for requesting cookies in a GET request. Updated to Connection Manager for 9.0

Added

  • pretty serial hierarchy view
  • general code cleanup and improvements
  • added disable=import-error to make Pylint happy.
  • imports sorted
  • uses settings.toml by default
  • using Connection Manager by default
  • cookie emoji

Serial output example:

Connecting to WiFi...
✅ Wifi!
 | Fetching Cookies: https://www.adafruit.com
 | Total Cookies: 3
--------------------------------------------------------------------------------
 | 🍪 zenid=cqf625rcrijkg48l4gto; expires=Mon, 08-Apr-2024 07:22:59 GMT; Max-Age=1209600; path=/; domain=.adafruit.com; secure; HttpOnly
--------------------------------------------------------------------------------
 | 🍪 cart_count=0; expires=Mon, 08-Apr-2024 07:22:59 GMT; Max-Age=1209600; path=/; domain=.adafruit.com
--------------------------------------------------------------------------------
 | 🍪 wishlist=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; Max-Age=0; path=/; domain=.adafruit.com
--------------------------------------------------------------------------------
✂️ Disconnected from https://www.adafruit.com
Finished!

@DJDevon3
Update multiple cookies example
08422e8 
Example for requesting cookies in a GET request. Updated to Connection Manager for 9.0
FoamyGuy
FoamyGuy requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of the pylint disable comment.

examples/wifi/expanded/requests_wifi_multiple_cookies.py Outdated Show resolved Hide resolved
@DJDevon3
removed pylint:disable=import-error
240a858 
yeah these will pass adafruit actions pylint but not my own.  will just ignore them on my end from now on.
FoamyGuy
FoamyGuy approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you

@FoamyGuy FoamyGuy merged commit 4f88beb into adafruit:main Apr 10, 2024
1 check passed
@DJDevon3 DJDevon3 deleted the DJDevon3-MultipleCookies branch April 10, 2024 23:23
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 11, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@38b61d2)
01d2287 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 3.2.4 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#184 from DJDevon3/GithubAPI
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#177 from DJDevon3/DJDevon3-WifiSimpleTest
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#176 from DJDevon3/DJDevon3-MultipleCookies
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#167 from DJDevon3/DJDevon3-openskynetwork_private
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#168 from DJDevon3/DJDevon3-openskynetwork_private_area

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJDevon3 @FoamyGuy