-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to ruff #171
Closed
Closed
Switch to ruff #171
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0a0ebd7
Switch to ruff
justmobilize 815bab9
Add PL (pylint) and UP (pyupgrade)
justmobilize bd275ba
Add ruff formatter
justmobilize 004b210
Add ruff isort
justmobilize 00c1bcd
Add ruff lint
justmobilize 2f8ae41
Add ruff upgrade
justmobilize aa5bd16
remove upgrade UP028
justmobilize f5a8022
remove upgrade UP031
justmobilize e26ab09
remove upgrade UP032
justmobilize 0bd03c4
Merge branch 'ruff-updates' into ruff
justmobilize File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries | ||
# | ||
# SPDX-License-Identifier: Unlicense | ||
|
||
* text eol=lf | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,47 +1,21 @@ | ||
# SPDX-FileCopyrightText: 2020 Diego Elio Pettenò | ||
# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries | ||
# | ||
# SPDX-License-Identifier: Unlicense | ||
|
||
repos: | ||
- repo: https://github.com/python/black | ||
rev: 24.2.0 | ||
hooks: | ||
- id: black | ||
- repo: https://github.com/PyCQA/isort | ||
rev: 5.13.2 | ||
hooks: | ||
- id: isort | ||
args: ["--profile", "black", "--filter-files"] | ||
- repo: https://github.com/fsfe/reuse-tool | ||
rev: v1.1.2 | ||
hooks: | ||
- id: reuse | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.4.0 | ||
rev: v4.5.0 | ||
hooks: | ||
- id: check-yaml | ||
- id: end-of-file-fixer | ||
- id: trailing-whitespace | ||
- repo: https://github.com/pycqa/pylint | ||
rev: v2.17.4 | ||
- repo: https://github.com/astral-sh/ruff-pre-commit | ||
rev: v0.3.4 | ||
hooks: | ||
- id: ruff-format | ||
- id: ruff | ||
args: ["--fix"] | ||
- repo: https://github.com/fsfe/reuse-tool | ||
rev: v3.0.1 | ||
hooks: | ||
- id: pylint | ||
name: pylint (library code) | ||
types: [python] | ||
args: | ||
- --disable=consider-using-f-string | ||
exclude: "^(docs/|examples/|tests/|setup.py$)" | ||
- id: pylint | ||
name: pylint (example code) | ||
description: Run pylint rules on "examples/*.py" files | ||
types: [python] | ||
files: "^examples/" | ||
args: | ||
- --disable=consider-using-f-string,duplicate-code,missing-docstring,invalid-name | ||
- id: pylint | ||
name: pylint (test code) | ||
description: Run pylint rules on "tests/*.py" files | ||
types: [python] | ||
files: "^tests/" | ||
args: | ||
- --disable=consider-using-f-string,duplicate-code,missing-docstring,invalid-name,protected-access,redefined-outer-name | ||
- id: reuse |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
.gitattributes
for helping with Windows? I haven't had an issue withruff
and EOLs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for helping with windows, not specifically related to
ruff
but was discussed in the same larger conversation during the meeting.Though my understanding is this was a fix for something that pylint complained about, perhaps with ruff replacing pylint we may not need this change any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make sure they commit fine, even if they forget to run pre-commit, allowing small changes to still pass CI