Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This should fix the adafruit_lsm6ds related issue #38

Merged
merged 2 commits into from
Aug 23, 2020
Merged

This should fix the adafruit_lsm6ds related issue #38

merged 2 commits into from
Aug 23, 2020

Conversation

dglaude
Copy link
Contributor

@dglaude dglaude commented Aug 23, 2020

Not tested yet... WiP.

Could fix #37

@dglaude
Copy link
Contributor Author

dglaude commented Aug 23, 2020

Works for me, tested with Adafruit_Learning_System_Guides-master\CLUE_Beacon

@dglaude
Fighting new PyLint message
accc22c 
************* Module pybadger_pyportal_touchscreen
examples/pybadger_pyportal_touchscreen.py:4:0: C0411: third party import "import adafruit_touchscreen" should be placed before "from adafruit_pybadger import pybadger" (wrong-import-order)
FoamyGuy
FoamyGuy approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on CLUE with this minimal script:

from adafruit_pybadger import pybadger
print(pybadger.acceleration)

Confirmed these changes are working successfully with the newest version of adafruit_lsm6ds library.

@ladyada ladyada merged commit 8f9a28c into adafruit:master Aug 23, 2020
@dglaude dglaude deleted the patch-1 branch August 24, 2020 07:50
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 25, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b17b8fd)
3900498 
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#38 from dglaude/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_TC74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Another victim of lsm6ds33.
3 participants
@dglaude @FoamyGuy @ladyada