Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inital progress value drawing #13

Merged
merged 1 commit into from
Aug 5, 2020
Merged

fix inital progress value drawing #13

merged 1 commit into from
Aug 5, 2020

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Aug 3, 2020

This solves #12.

With this change we will first set the progress value to 0.0 and then update it to the value that was passed to init() which allows it to get drawn correctly

@FoamyGuy FoamyGuy assigned FoamyGuy and unassigned FoamyGuy Aug 5, 2020
@FoamyGuy FoamyGuy requested a review from a team August 5, 2020 03:00
@FoamyGuy FoamyGuy added the bug Something isn't working label Aug 5, 2020
brentru
brentru approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and corrects issue #12.

jepler
jepler approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but didn't test.

@jepler jepler merged commit 247b51d into adafruit:master Aug 5, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 7, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@20501cf)
5ae9831 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.0.0 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#14 from 2bndy5/master
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#16 from brentru/attribute-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 4.0.0 from 3.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#46 from 2bndy5/remove-loop_forever()

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#13 from FoamyGuy/fix_inital_progress
@FoamyGuy FoamyGuy mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FoamyGuy @brentru @jepler