Some pimoroni improvement on UART and __init__ #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of @Gadgetoid change from pimoroni@3e59013
This was referenced Nov 15, 2020
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 18, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.3.4 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#52 from chadkuester/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#51 from taotien/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PM25#12 from dglaude/some_pimoroni_improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Gadgetoid made 4 improvement in 3 separate commit in https://github.com/pimoroni/Adafruit_CircuitPython_PM25
After testing, reapplied 2 commit as is and only one of the two improvement from the last commit.
All those code change are from @Gadgetoid, I don't know how to maintain the credit for those.