feat: add support for binary messages #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Jan 7, 2022
f05b92d to
efe8b4b
Compare
efe8b4b to
1bdaca8
Compare
brentru
approved these changes
Jan 11, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 19, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#30 from tekktrik/doc/fix-code-block Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.6.0 from 3.5.14: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#150 from tekktrik/feature/configurable-eol > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#151 from tekktrik/feature/add-recvinto > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#152 from tekktrik/hotfix/fix-docs > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#149 from tekktrik/doc/add-missing-to-api Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.3.13 from 1.3.12: > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#33 from tekktrik/doc/update-documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.2.0 from 4.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#88 from jposada202020/including_animation_class Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 6.2.0 from 6.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#120 from FoamyGuy/force_content_type Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.5.2 from 2.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#32 from FoamyGuy/alt_click Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.10 from 2.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#33 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#31 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.2.0 from 5.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#97 from goliothlabs/feat/add-binary-support Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.6.0 from 0.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#29 from jepler/program-object
rtwfroody
pushed a commit
to rtwfroody/Adafruit_CircuitPython_MiniMQTT
that referenced
this pull request
Sep 18, 2022
feat: add support for binary messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a basic client library to use with Golioth Platform. We recently added a new gateway to support MQTT devices and that allows us to add support to CircuitPython.
But while developing the client, we had issues with one of our services meant for Over the Air Updates, which serves not only for the main device firmware, but you can send any arbitrary artifact ( like images/bitmap in my testing here). Currently, this MQTT library tries to convert all messages to a Unicode string, which unfortunately fails for binary data. Reference to where it fails: https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/blob/main/adafruit_minimqtt/adafruit_minimqtt.py#L843
So what I'm proposing here is to add an optional parameter called
use_binary, that would allow users to use the MQTT client in binary mode and return the rawbytearraymessage. Them is up to the user to convert to a string as needed.