Improve network handling and implement time-based KeepAlive #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Aug 15, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 15, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3502 to 1.0.2 from 1.0.1: > fixing documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#11 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to v1.1.0 from v1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#4 from brentru/master
rtwfroody
pushed a commit
to rtwfroody/Adafruit_CircuitPython_MiniMQTT
that referenced
this pull request
Sep 18, 2022
Improve network handling and implement time-based KeepAlive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how the library handles the MQTT KeepAlive with the initial CONNECT packet [MQTT-3.1.2-23]. We'll connect to a server, and stay connected.
keep_aliveexposed as an init kwarg - different brokers expect differentkeeep_alivevalues and a user may also want to set this value manually.loopmethod now checks the time and sends a PINGREQ (expecting a PINGRESP, this is handled in theping()method) to the server if the time elapsed is greater than or equal to the provided keepalive value.loop_forevermethod has been refactored to callloopinstead of_wait_for_msg. This method also now handles network control, for both the socket and the NetworkManager (currently WiFiManager) objects.is_wifi_connected,is_sock_connected) have been added as well as additional management for both the socket and ESP32SPI wifi module (reconnect_socket,reconnect_wifi)Before this patch was applied:
After:
