Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCP32xx (12 bit) ADC support and optional baudrate parameter for SPI comms #47

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kevinjwalters
Copy link

This adds support for the MCP3202, MCP3204, MCP3208. I've been testing a lot on an MCP3208. #41

I've changed code a bit for MCP30xx but do not own one so have not tested that.

Added baudrate as a new optional parameter retaining the original 100kHz default. #46

Kevin J Walters added 3 commits September 2, 2024 23:54
Three new sub-classes, read method now appears in all sub-classes, constructor only in parent.
AnalogIn.value uses calculated shift values based on new class variable BITS.
adafruit#41
@kevinjwalters
Copy link
Author

There's also a 13bit MCP33xx series...

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @kevinjwalters!

The changes look good to me. Though I will say I don't have any experience with these MCP3XXX devices and not much with ADCs more generally.

I don't have the hardware to test with.

As far as I can tell this is the main product that this library supported: https://www.adafruit.com/product/856 It's listed as out of stock now, but if anyone has access to one and is willing to test out this branch with it to ensure backwards compatibility please let us know how it goes if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants