Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples renamed to match lib names #16

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

magnusvmt
Copy link
Contributor

Solves issue #15

@2bndy5
Copy link
Contributor

2bndy5 commented Oct 9, 2019

I noticed the docs pages are missing everything in the "API Reference" page, so I started a fork to fix it. However, is it just me or is the example for MCP3004 single-ended reads setup exactly like the MCP3004 differential reads example (maybe a copy and paste issue). Specifically, the third argument in chan = AnalogIn(mcp, MCP.P0, MCP.P1) should not be specified for single-ended reads, right?

@magnusvmt
Copy link
Contributor Author

@2bndy5 Yes you're right. The third argument should not be there for the single ended MCP3004 test!

@brentru brentru requested a review from a team October 9, 2019 16:01
@brentru
Copy link
Member

brentru commented Oct 9, 2019

@magnusvmt Thanks for the PR, merging in and releasing!

@2bndy5 You're correct, could you open a separate PR addressing the docs issue for single-ended reads? Thanks!

@brentru brentru merged commit 403c063 into adafruit:master Oct 9, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 9, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.0.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#77 from brentru/add-certificate-handlers

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP3xxx to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP3xxx#16 from magnusvmt/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 2.1.0 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#21 from brentru/close-responses
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#27 from brentru/callbacks-for-sub-unsub

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#9 from brentru/cert-example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants