Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed busio.i2c to board.i2c #42

Merged
merged 4 commits into from
May 6, 2020
Merged

Changed busio.i2c to board.i2c #42

merged 4 commits into from
May 6, 2020

Conversation

evaherrada
Copy link
Collaborator

I'm not sure if I've got the hardware to test. I've got a gps featherwing, although I've never tried using it over i2c.

@evaherrada evaherrada requested a review from dhalbert March 27, 2020 18:08
@evaherrada
Copy link
Collaborator Author

In reference to #42

examples/gps_datalogging.py Outdated Show resolved Hide resolved
@@ -18,7 +18,7 @@
# uart = serial.Serial("/dev/ttyUSB0", baudrate=9600, timeout=10)

# If using I2C, we'll create an I2C interface to talk to using default pins
# i2c = busio.I2C(board.SCL, board.SDA)
# i2c = board.I2C(board.SCL, board.SDA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

examples/gps_simpletest.py Outdated Show resolved Hide resolved
@kattni kattni requested a review from dhalbert April 29, 2020 20:54
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhalbert dhalbert merged commit 82ecc0c into adafruit:master May 6, 2020
@evaherrada evaherrada deleted the i2c-fix branch May 7, 2020 15:59
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 8, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.4.0 from 3.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#97 from dearmash/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.6.3 from 3.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#45 from adafruit/dherrada-patch-2
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#42 from dherrada/i2c-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_MSA301 to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#5 from geekguy-wy/needs_renaming_to_match_lib_name
  > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#4 from BiffoBear/rename-example-file

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.2.4 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#81 from kattni/remove-from-pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#17 from adafruit/lux-note

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 2.2.1 from 2.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#32 from brentru/add-cellular

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#27 from brentru/add-cellular
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants