-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed busio.i2c to board.i2c #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reference to #42 |
dhalbert
requested changes
Mar 27, 2020
examples/gps_echotest.py
Outdated
@@ -18,7 +18,7 @@ | |||
# uart = serial.Serial("/dev/ttyUSB0", baudrate=9600, timeout=10) | |||
|
|||
# If using I2C, we'll create an I2C interface to talk to using default pins | |||
# i2c = busio.I2C(board.SCL, board.SDA) | |||
# i2c = board.I2C(board.SCL, board.SDA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
dhalbert
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 8, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.4.0 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#97 from dearmash/master Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.6.3 from 3.6.1: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#45 from adafruit/dherrada-patch-2 > Merge pull request adafruit/Adafruit_CircuitPython_GPS#42 from dherrada/i2c-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_MSA301 to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#5 from geekguy-wy/needs_renaming_to_match_lib_name > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#4 from BiffoBear/rename-example-file Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.2.4 from 3.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#81 from kattni/remove-from-pypi Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.2.2 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#17 from adafruit/lux-note Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 2.2.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#32 from brentru/add-cellular Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#27 from brentru/add-cellular
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I've got the hardware to test. I've got a gps featherwing, although I've never tried using it over i2c.